morningman commented on a change in pull request #3744:
URL: https://github.com/apache/incubator-doris/pull/3744#discussion_r439830474
##########
File path: docs/zh-CN/administrator-guide/http-actions/connection-action.md
##########
@@ -0,0 +1,36 @@
+---
+{
+ "title": "CONNECTION",
+ "language": "en"
Review comment:
```suggestion
"language": "zh-CN"
```
##########
File path: docs/zh-CN/administrator-guide/http-actions/connection-action.md
##########
@@ -0,0 +1,36 @@
+---
+{
+ "title": "CONNECTION",
+ "language": "en"
+}
+---
+
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+# CONNECTION
+## description
Review comment:
中文文档使用中文标题
##########
File path: fe/src/main/java/org/apache/doris/common/Log4jConfig.java
##########
@@ -179,10 +179,6 @@ private static void reconfig() throws IOException {
strSub = new StrSubstitutor(new Interpolator(properties));
newXmlConfTemplate = strSub.replace(newXmlConfTemplate);
- System.out.println("=====");
Review comment:
Why removing this?
##########
File path: docs/zh-CN/administrator-guide/http-actions/query-detail-action.md
##########
@@ -0,0 +1,37 @@
+---
+{
+ "title": "QUERY DETAIL",
+ "language": "en"
Review comment:
```suggestion
"language": "zh-CN"
```
##########
File path: fe/src/main/java/org/apache/doris/PaloFe.java
##########
@@ -73,7 +73,6 @@ public static void start(String dorisHomeDir, String pidDir,
String[] args) {
}
CommandLineOptions cmdLineOpts = parseArgs(args);
- System.out.println(cmdLineOpts.toString());
Review comment:
Why removing this?
##########
File path: docs/zh-CN/administrator-guide/http-actions/connection-action.md
##########
@@ -0,0 +1,36 @@
+---
+{
+ "title": "CONNECTION",
+ "language": "en"
+}
+---
+
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+# CONNECTION
+## description
+
+ 通过connection_id, 获取当前连接的query_id
+
+ URI: http://fe_host:fe_http_port/api/connection?connection_id=123
+
+## example
Review comment:
需要给出api的返回结果示例
##########
File path: fe/src/main/java/org/apache/doris/qe/QueryDetailQueue.java
##########
@@ -0,0 +1,71 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.qe;
+
+import com.google.common.collect.Lists;
+import com.google.common.collect.Maps;
+import java.util.Iterator;
+import java.util.LinkedList;
+import java.util.List;
+import java.util.Map;
+import org.apache.doris.qe.QueryDetail;
+
+// Queue of QueryDetail.
+// It's used to collect queries for monitor.
+// The default copacity is 10000.
+public class QueryDetailQueue {
Review comment:
Add unit test for this class
##########
File path: docs/zh-CN/administrator-guide/http-actions/query-detail-action.md
##########
@@ -0,0 +1,37 @@
+---
+{
+ "title": "QUERY DETAIL",
+ "language": "en"
+}
+---
+
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+# QUERY DETAIL
+## description
+
+ 从FE获取所有的query细节，获取关于查询执行的相关信息。
+ event_time的单位是毫秒。
Review comment:
需要说明 event_time 的含义，比如是获取从 event_time 之后的所有 query 的执行情况
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
