yiguolei commented on code in PR #20349: URL: https://github.com/apache/doris/pull/20349#discussion_r1213813762
########## be/src/olap/delete_handler.cpp: ########## @@ -110,7 +110,7 @@ std::string DeleteHandler::construct_sub_predicates(const TCondition& condition) } else if (op == "!*=") { op = "!="; } - condition_str = condition.column_name + op + condition.condition_values[0]; + condition_str = condition.column_name + op + "'" + condition.condition_values[0] + "'"; Review Comment: If we upgrade from doris 1.2 and there is a delete condition. It does not contains '', is there error? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org