SaintBacchus commented on code in PR #20265:
URL: https://github.com/apache/doris/pull/20265#discussion_r1211551808
##########
fe/fe-core/src/main/java/org/apache/doris/mtmv/MTMVTaskManager.java:
##########
@@ -58,10 +58,11 @@ public class MTMVTaskManager {
private static final Logger LOG =
LogManager.getLogger(MTMVTaskManager.class);
- // jobId -> pending tasks, one job can dispatch many tasks
- private final Map<Long, PriorityBlockingQueue<MTMVTaskExecutor>>
pendingTaskMap = Maps.newConcurrentMap();
+ // mvId -> jobId -> pending tasks, one job can dispatch many tasks
+ private final Map<Long, Map<Long,
PriorityBlockingQueue<MTMVTaskExecutor>>> pendingTaskMap = Maps
+ .newConcurrentMap();
- // jobId -> running tasks, only one task will be running for one job.
+ // mvId -> running tasks, only one task will be running for one job.
Review Comment:
can we here use `mvId -> jobId -> taskid`?
One mv will contains many jobs but only one in running status.
One job will contain many tasks and tasks can be executed paralism
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
