CalvinKirs commented on code in PR #18: URL: https://github.com/apache/doris-shade/pull/18#discussion_r1211065891
########## hive-catalog-shade/pom.xml: ########## @@ -285,49 +286,55 @@ under the License. </exclusions> </dependency> <dependency> - <groupId>org.apache.hive</groupId> - <artifactId>hive-standalone-metastore</artifactId> - <version>${hive.version}</version> + <groupId>org.apache.paimon</groupId> + <artifactId>paimon-hive-connector-3.1</artifactId> + <version>${paimon-hive-metastore.version}</version> Review Comment: `hive-standalone-metastore` is the main dependency of all catalogs. I suggest that paimon-related dependencies move closer to it instead of replacing it, otherwise it will heavily rely on the hive version of paimon in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org