SaintBacchus commented on code in PR #20108:
URL: https://github.com/apache/doris/pull/20108#discussion_r1209638261
##########
fe/fe-core/src/main/java/org/apache/doris/mtmv/MTMVJobFactory.java:
##########
@@ -42,18 +41,8 @@ public class MTMVJobFactory {
private static final Logger LOG =
LogManager.getLogger(MTMVTaskProcessor.class);
public static boolean isGenerateJob(MaterializedView materializedView) {
- boolean completeRefresh =
materializedView.getRefreshInfo().getRefreshMethod() == RefreshMethod.COMPLETE;
- BuildMode buildMode = materializedView.getBuildMode();
- MVRefreshTriggerInfo triggerInfo =
materializedView.getRefreshInfo().getTriggerInfo();
//can not generate a job when creating a temp materialized view.
- if
(materializedView.getName().startsWith(FeConstants.TEMP_MATERIZLIZE_DVIEW_PREFIX))
{
- return false;
- }
- if (buildMode == BuildMode.IMMEDIATE) {
- return completeRefresh;
- } else {
- return completeRefresh && triggerInfo != null &&
triggerInfo.getRefreshTrigger() == RefreshTrigger.INTERVAL;
- }
+ return
!materializedView.getName().startsWith(FeConstants.TEMP_MATERIZLIZE_DVIEW_PREFIX);
Review Comment:
If there is no job in the mv create stmt, will this generate a job?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
