chaoyli commented on a change in pull request #3820: URL: https://github.com/apache/incubator-doris/pull/3820#discussion_r438238608
########## File path: be/src/runtime/buffered_block_mgr2.cc ########## @@ -210,8 +210,7 @@ BufferedBlockMgr2::BufferedBlockMgr2(RuntimeState* state, TmpFileMgr* tmp_file_m _max_block_size(block_size), // Keep two writes in flight per scratch disk so the disks can stay busy. _block_write_threshold(tmp_file_mgr->num_active_tmp_devices() * 2), - // _disable_spill(state->query_ctx().disable_spilling), - _disable_spill(false), + _disable_spill(state->disable_spill()), Review comment: use enable_spill is better which is compatible to fe ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org