AshinGau commented on code in PR #19819:
URL: https://github.com/apache/doris/pull/19819#discussion_r1208983499
##########
fe/java-udf/src/main/java/org/apache/doris/jni/vec/ScanPredicate.java:
##########
@@ -119,6 +119,11 @@ public String toString() {
return inspectObject().toString();
}
+ @Override
+ public boolean isNull() {
+ return (boolean) inspectObject();
Review Comment:
`isNull` is not `getBoolean`.
##########
fe/java-udf/src/main/java/org/apache/doris/jni/vec/VectorColumn.java:
##########
@@ -556,7 +559,8 @@ public void appendValue(ColumnValue o) {
case DECIMAL32:
case DECIMAL64:
case DECIMAL128:
- appendDecimal(o.getDecimal());
Review Comment:
Why add an intermediate result?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
