nextdreamblue commented on PR #20064: URL: https://github.com/apache/doris/pull/20064#issuecomment-1566413395
> The name `return_load_in_sink` is related to internal implementation, not suitable for a user-oriented config' name. > > There are 2 issues you want to solve in #19259 > > 1. Test load performance > I think it is better to use a session variable or load properties for this case. You can see there a session variable `dry_run_query`, when set to true, it will run the query without return the result. It resolve the similar issue as you want to resolve. > 2. For materialized view. > This is indeed a table property. I suggest to think about new property name instead of exposing the internal implements. > Eg: `"storage_policy" = "no_storage"`. (There is already a "storage_policy" used for cold-hot data separation, maybe we can expend it) > > All in all, my opinion is that the 2 things you want to resolve are 2 different cases. Better design it carefully to avoid adding confusing properties. 1. I discussed with dataroaring before that session variable may affect all users and tables, and users may not be aware of the data not being loaded in a timely manner, which may result in unexpected data loss and high risks. It is recommended to use table properties, and I will modify a user-friendly name. 2. For materialized view, i will implement it in another branch and may introduce students from Doris-future to participate. and will follow your suggestion that add a table property -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
