airborne12 commented on code in PR #20116: URL: https://github.com/apache/doris/pull/20116#discussion_r1208018038
########## be/src/olap/rowset/segment_v2/inverted_index_writer.cpp: ########## @@ -215,13 +221,9 @@ class InvertedIndexColumnWriterImpl : public InvertedIndexColumnWriter { } void new_fulltext_field(const char* field_value_data, size_t field_value_size) { - if (_parser_type == InvertedIndexParserType::PARSER_ENGLISH) { + if (_parser_type == InvertedIndexParserType::PARSER_ENGLISH || + _parser_type == InvertedIndexParserType::PARSER_CHINESE) { new_char_token_stream(field_value_data, field_value_size, _field); - } else if (_parser_type == InvertedIndexParserType::PARSER_CHINESE) { Review Comment: use char to avoid copy data in both english and chinese analyzer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org