LiBinfeng-01 commented on code in PR #19807:
URL: https://github.com/apache/doris/pull/19807#discussion_r1206480034
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/ComparisonPredicate.java:
##########
@@ -58,4 +59,16 @@ public AbstractDataType inputType() {
* Commute between left and right children.
*/
public abstract ComparisonPredicate commute();
+
+ @Override
+ public TypeCheckResult checkInputDataTypes() {
+ for (int i = 0; i < super.children().size(); i++) {
+ Expression input = super.children().get(i);
+ if (input.getDataType().isBitmapType()) {
Review Comment:
done
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/SubExprAnalyzer.java:
##########
@@ -119,6 +120,12 @@ private boolean
childrenAtLeastOneInOrExistsSub(BinaryOperator binaryOperator) {
|| binaryOperator.right().anyMatch(Exists.class::isInstance);
}
+ private boolean childrenAtLeastOneIsBitMapType(Expression binaryOperator) {
+ return binaryOperator.getArgument(0).getDataType() instanceof
BitmapType
+
+ || binaryOperator.getArgument(1).getDataType() instanceof
BitmapType;
+ }
+
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
