EmmyMiao87 commented on a change in pull request #3739:
URL: https://github.com/apache/incubator-doris/pull/3739#discussion_r436441647
##########
File path: fe/src/main/java/org/apache/doris/alter/RollupJobV2.java
##########
@@ -352,14 +353,21 @@ protected void runWaitingTxnJob() throws
AlterCancelException {
long rollupTabletId = rollupTablet.getId();
long baseTabletId = tabletIdMap.get(rollupTabletId);
+ Map<String, Expr> defileExprs = Maps.newHashMap();
Review comment:
defileExpr? or defineExpr?
##########
File path: fe/src/main/java/org/apache/doris/task/AlterReplicaTask.java
##########
@@ -38,10 +46,22 @@
private long jobId;
private AlterJobV2.JobType jobType;
+ private Map<String, Expr> defileExprs;
Review comment:
defineExpr
##########
File path: fe/src/main/java/org/apache/doris/task/AlterReplicaTask.java
##########
@@ -93,6 +115,15 @@ public TAlterTabletReqV2 toThrift() {
TAlterTabletReqV2 req = new TAlterTabletReqV2(baseTabletId, signature,
baseSchemaHash, newSchemaHash);
req.setAlter_version(version);
req.setAlter_version_hash(versionHash);
+ if (defileExprs != null) {
Review comment:
Please add some comments and example of bitmap or hll
##########
File path: fe/src/main/java/org/apache/doris/task/AlterReplicaTask.java
##########
@@ -93,6 +115,15 @@ public TAlterTabletReqV2 toThrift() {
TAlterTabletReqV2 req = new TAlterTabletReqV2(baseTabletId, signature,
baseSchemaHash, newSchemaHash);
req.setAlter_version(version);
req.setAlter_version_hash(versionHash);
+ if (defileExprs != null) {
+ for (Map.Entry<String, Expr> expr : defileExprs.entrySet()) {
+ List<SlotRef> slots = Lists.newArrayList();
+ expr.getValue().collect(SlotRef.class, slots);
+ Preconditions.checkState(slots.size() == 1);
Review comment:
The expr must be contain only one slot after analyzing.
##########
File path: fe/src/main/java/org/apache/doris/task/AlterReplicaTask.java
##########
@@ -93,6 +115,15 @@ public TAlterTabletReqV2 toThrift() {
TAlterTabletReqV2 req = new TAlterTabletReqV2(baseTabletId, signature,
baseSchemaHash, newSchemaHash);
req.setAlter_version(version);
req.setAlter_version_hash(versionHash);
+ if (defileExprs != null) {
+ for (Map.Entry<String, Expr> expr : defileExprs.entrySet()) {
Review comment:
`for(Map.Entry<String, Expr> entry: defineExprs.entrySet())`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
