xinyiZzz commented on code in PR #20048: URL: https://github.com/apache/doris/pull/20048#discussion_r1205211563
########## fe/fe-core/src/main/java/org/apache/doris/resource/resourcegroup/QueryQueue.java: ########## @@ -0,0 +1,103 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.resource.resourcegroup; + +import com.google.common.base.Preconditions; +import org.apache.logging.log4j.LogManager; +import org.apache.logging.log4j.Logger; + +import java.util.concurrent.TimeUnit; +import java.util.concurrent.locks.Condition; +import java.util.concurrent.locks.ReentrantLock; + +// note(wb) refer java BlockingQueue, but support altering capacity +// todo(wb) add wait time to profile +public class QueryQueue { + + private static final Logger LOG = LogManager.getLogger(QueryQueue.class); + // note(wb) use fair strategy for FIFO + // but maybe display lower overall throughput + // need performance test later + private final ReentrantLock queueLock = new ReentrantLock(true); + private final Condition queueLockCond = queueLock.newCondition(); + // resource group property + private int maxRunningQueryNum; + private int maxWaitingQueryNum; + private int queryWaitTimeout; // ms + // running property + private int currentRunningQueryNum; + private int currentWaitingQueryNum; + + public QueryQueue(int maxRunningQueryNum, int maxWaitingQueryNum, int queryWaitTimeout) { + this.maxRunningQueryNum = maxRunningQueryNum; + this.maxWaitingQueryNum = maxWaitingQueryNum; + this.queryWaitTimeout = queryWaitTimeout; + } + + public void offer() throws InterruptedException { + // to prevent hang + // the lock shouldn't be hold for too long + // we should catch the case when it happens + queueLock.tryLock(5, TimeUnit.SECONDS); + try { + // currentRunningQueryNum may bigger than maxRunningQueryNum + // because maxRunningQueryNum can be altered + if (currentRunningQueryNum >= maxRunningQueryNum) { + if (currentWaitingQueryNum >= maxWaitingQueryNum) { + throw new QueryQueueException( + "query waiting queue is full, queue length=" + maxWaitingQueryNum); + } + + currentWaitingQueryNum++; + boolean ret = queueLockCond.await(queryWaitTimeout, TimeUnit.MILLISECONDS); + currentWaitingQueryNum--; + if (!ret) { + throw new QueryQueueException("query wait timeout " + queryWaitTimeout + " ms"); + } + } + currentRunningQueryNum++; + } finally { + queueLock.unlock(); + } + } + + public void poll() throws InterruptedException { + queueLock.tryLock(5, TimeUnit.SECONDS); + try { + currentRunningQueryNum--; Review Comment: Whether to print the log fe.log regularly, print `currentRunningQueryNum` and `currentWaitingQueryNum` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
