Reminiscent opened a new pull request, #20053:
URL: https://github.com/apache/doris/pull/20053

   
   ## Problem summary
   We can not use the string as the variable key to use in the hint.
   Before this PR
   ```
   mysql> SET enable_nereids_planner=true;
   Query OK, 0 rows affected (0.01 sec)
   
   mysql> set enable_fallback_to_original_planner=false;
   Query OK, 0 rows affected (0.10 sec)
   
   mysql> explain select /*+ SET_var("enable_nereids_planner" = "false") */ 1;
   ERROR 1105 (HY000): Exception, msg: Nereids cannot parse the SQL, and 
fallback disabled. caused by: 
   
   
   no viable alternative at input 'select /*+ 
SET_var("enable_nereids_planner"'(line 1, pos 27)
   ```
   
   After this PR
   ```
   mysql> SET enable_nereids_planner=true;
   Query OK, 0 rows affected (0.01 sec)
   
   mysql> set enable_fallback_to_original_planner=false;
   Query OK, 0 rows affected (0.10 sec)
   
   mysql> select /*+ SET_var("enable_nereids_planner" = "false") */ 1; 
   +------+
   | 1    |
   +------+
   |    1 |
   +------+
   1 row in set (0.00 sec)
   ```
   
   Describe your changes.
   Support the string for the hint key in the Parser.
   
   ## Checklist(Required)
   
   * [ ] Does it affect the original behavior
   * [ ] Has unit tests been added
   * [ ] Has document been added or modified
   * [ ] Does it need to update dependencies
   * [ ] Is this PR support rollback (If NO, please explain WHY)
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to