jackwener commented on code in PR #20051:
URL: https://github.com/apache/doris/pull/20051#discussion_r1205111186


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/memo/Memo.java:
##########
@@ -111,7 +111,8 @@ public Map<GroupExpression, GroupExpression> 
getGroupExpressions() {
     }
 
     private Plan skipProject(Plan plan, Group targetGroup) {
-        if (plan instanceof LogicalProject) {
+        // Some top project can't be eliminated
+        if (plan instanceof LogicalProject && ((LogicalProject<?>) 
plan).canEliminate()) {

Review Comment:
   Can't skip project whose canEliminate() is true 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to