yiguolei commented on code in PR #20007: URL: https://github.com/apache/doris/pull/20007#discussion_r1203958199
########## be/src/pipeline/exec/operator.h: ########## @@ -286,7 +286,11 @@ class DataSinkOperator : public OperatorBase { Status sink(RuntimeState* state, vectorized::Block* in_block, SourceState source_state) override { Review Comment: why should we check it here? why not return ok in send method? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org