Mryange commented on code in PR #19926:
URL: https://github.com/apache/doris/pull/19926#discussion_r1201600387
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/ArithmeticExpr.java:
##########
@@ -536,7 +536,7 @@ private void analyzeDecimalV3Op(Type t1, Type t2) throws
AnalysisException {
public void analyzeImpl(Analyzer analyzer) throws AnalysisException {
if (VectorizedUtil.isVectorized()) {
for (Expr child : children) {
- if (child instanceof DecimalLiteral &&
child.getType().isDecimalV3()) {
+ if (child instanceof DecimalLiteral &&
child.getType().isDecimalV3() && !child.getIsCasted()) {
((DecimalLiteral) child).tryToReduceType();
Review Comment:
I asked the author about this code, and they said it was meant to reduce
precision during calculations. now it seems better to remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
