morningman commented on code in PR #19868: URL: https://github.com/apache/doris/pull/19868#discussion_r1199144172
########## be/src/common/config.cpp: ########## @@ -388,6 +388,9 @@ DEFINE_mInt32(base_compaction_trace_threshold, "60"); DEFINE_mInt32(cumulative_compaction_trace_threshold, "10"); DEFINE_mBool(disable_compaction_trace_log, "true"); +// Interval to picking rowset to compact, in milliseconds +DEFINE_mInt64(pick_rowset_to_compact_interval, "86400000"); Review Comment: Add time unit to the config name. And I suggest to use second. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
