yiguolei commented on code in PR #19594: URL: https://github.com/apache/doris/pull/19594#discussion_r1197660106
########## be/src/vec/data_types/convert_field_to_type.cpp: ########## @@ -94,8 +96,9 @@ Field convert_numeric_type_impl(const Field& from) { } return result; } + template <typename To> -Status convert_numric_type(const Field& from, const IDataType& type, Field* to) { +void convert_numric_type(const Field& from, const IDataType& type, Field* to) { Review Comment: numric? or number? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org