yiguolei commented on code in PR #19764:
URL: https://github.com/apache/doris/pull/19764#discussion_r1197657499
##########
be/src/runtime/client_cache.cpp:
##########
@@ -73,26 +69,19 @@ Status ClientCacheHelper::get_client(const TNetworkAddress&
hostport, ClientFact
Status ClientCacheHelper::reopen_client(ClientFactory& factory_method, void**
client_key,
int timeout_ms) {
DCHECK(*client_key != nullptr) << "Trying to reopen nullptr client";
- ThriftClientImpl* client_to_close = nullptr;
+ std::shared_ptr<ThriftClientImpl> client_to_close;
Review Comment:
Add macro ENABLE_FACTORY_CREATOR to ThriftClientImpl in order to force
using smart pointer please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
