github-actions[bot] commented on PR #19795: URL: https://github.com/apache/doris/pull/19795#issuecomment-1552599286
#### `sh-checker report` To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/5011465337") output. <details> <summary>shellcheck errors</summary> ``` 'shellcheck ' returned error 1 finding the following syntactical issues: ---------- In bin/start_be.sh line 23: if [ $(id -u) -eq 0 ]; then # current user has root privileges ^----------------^ SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh. ^------^ SC2046 (warning): Quote this to prevent word splitting. Did you mean: if [[ $(id -u) -eq 0 ]]; then # current user has root privileges In bin/start_be.sh line 27: sudo echo 1 > /proc/sys/vm/overcommit_memory ^-- SC2024 (warning): sudo doesn't affect redirects. Use ..| sudo tee file For more information: https://www.shellcheck.net/wiki/SC2024 -- sudo doesn't affect redirects. Us... https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt... https://www.shellcheck.net/wiki/SC2292 -- Prefer [[ ]] over [ ] for tests i... ---------- You can address the above issues in one of three ways: 1. Manually correct the issue in the offending shell script; 2. Disable specific issues by adding the comment: # shellcheck disable=NNNN above the line that contains the issue, where NNNN is the error code; 3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file. ``` </details> <details> <summary>shfmt errors</summary> ``` 'shfmt ' returned error 1 finding the following formatting issues: ---------- --- bin/start_be.sh.orig +++ bin/start_be.sh @@ -24,7 +24,7 @@ # system will no longer throw bad_alloc, memory alloc are always accepted, # memory limit check is handed over to Doris Allocator, make sure throw exception position is controllable, # otherwise bad_alloc can be thrown anywhere and it will be difficult to achieve exception safety. - sudo echo 1 > /proc/sys/vm/overcommit_memory + sudo echo 1 >/proc/sys/vm/overcommit_memory fi MACHINE_OS=$(uname -s) ---------- You can reformat the above files to meet shfmt's requirements by typing: shfmt -w filename ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org