xinyiZzz commented on code in PR #19622:
URL: https://github.com/apache/doris/pull/19622#discussion_r1196396232


##########
be/src/util/mem_info.cpp:
##########
@@ -113,6 +114,16 @@ void MemInfo::process_cache_gc(int64_t& freed_mem) {
                 
StoragePageCache::instance()->get_page_cache_mem_consumption(segment_v2::DATA_PAGE);
         StoragePageCache::instance()->prune(segment_v2::DATA_PAGE);
     }
+
+    if (segment_v2::InvertedIndexSearcherCache::instance()->mem_consumption() 
> min_free_size) {
+        freed_mem += 
segment_v2::InvertedIndexSearcherCache::instance()->mem_consumption();

Review Comment:
   `mem_consumption` is all cache memory, but here only the expired value is 
released.
   
   can let InvertedIndexSearcherCache -> prune return evict size, or do not add 
freed_mem here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to