Reminiscent commented on code in PR #18784:
URL: https://github.com/apache/doris/pull/18784#discussion_r1196114448
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalWindow.java:
##########
@@ -163,9 +163,8 @@ public int hashCode() {
* Check the window function. There are some restrictions for window
function:
* 1. The number of window function should be 1.
* 2. The window function should be one of the 'row_number()', 'rank()',
'dense_rank()'.
- * 3. The window type should be 'ROW'.
Review Comment:
The `rank` function will default use the `range`. And if the window frame is
'UNBOUNDED' to 'CURRENT', it's the same to use `range` or `row`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
