yixiutt commented on code in PR #19686: URL: https://github.com/apache/doris/pull/19686#discussion_r1195869279
########## be/src/olap/page_cache.cpp: ########## @@ -51,6 +52,10 @@ StoragePageCache::StoragePageCache(size_t capacity, int32_t index_cache_percenta } else { CHECK(false) << "invalid index page cache percentage"; } + if (pk_index_cache_capacity > 0) { + _pk_index_page_cache = std::unique_ptr<Cache>(new_lru_cache( Review Comment: We want pk index page to be seperated from storage page cache cause storage page cache may not enable by default, but pk index cache may always be enabled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org