This is an automated email from the ASF dual-hosted git repository.
gabriellee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 8f8814e49c [bugfix](be core) master info is deconstructed before
fragment mgr and be will core (#19687)
8f8814e49c is described below
commit 8f8814e49c66e437cb119bacc6ccad8368470056
Author: yiguolei <676222...@qq.com>
AuthorDate: Tue May 16 21:55:15 2023 +0800
[bugfix](be core) master info is deconstructed before fragment mgr and be
will core (#19687)
Co-authored-by: yiguolei <yiguo...@gmail.com>
---
be/src/runtime/exec_env_init.cpp | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/be/src/runtime/exec_env_init.cpp b/be/src/runtime/exec_env_init.cpp
index 7671f3c4ad..2b9b6f244b 100644
--- a/be/src/runtime/exec_env_init.cpp
+++ b/be/src/runtime/exec_env_init.cpp
@@ -373,7 +373,6 @@ void ExecEnv::_destroy() {
SAFE_DELETE(_broker_mgr);
SAFE_DELETE(_bfd_parser);
SAFE_DELETE(_load_path_mgr);
- SAFE_DELETE(_master_info);
SAFE_DELETE(_pipeline_task_scheduler);
SAFE_DELETE(_pipeline_task_group_scheduler);
SAFE_DELETE(_fragment_mgr);
@@ -386,6 +385,11 @@ void ExecEnv::_destroy() {
SAFE_DELETE(_external_scan_context_mgr);
SAFE_DELETE(_heartbeat_flags);
SAFE_DELETE(_scanner_scheduler);
+ // Master Info is a thrift object, it could be the last one to deconstruct.
+ // Master info should be deconstruct later than fragment manager, because
fragment will
+ // access master_info.backend id to access some info. If there is a
running query and master
+ // info is deconstructed then BE process will core at coordinator back
method in fragment mgr.
+ SAFE_DELETE(_master_info);
_send_batch_thread_pool.reset(nullptr);
_buffered_reader_prefetch_thread_pool.reset(nullptr);
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
