xinyiZzz commented on code in PR #19472:
URL: https://github.com/apache/doris/pull/19472#discussion_r1193834415
##########
be/src/olap/page_cache.h:
##########
@@ -28,11 +28,55 @@
#include "olap/lru_cache.h"
#include "util/slice.h"
+#include "vec/common/allocator.h"
+#include "vec/common/allocator_fwd.h"
namespace doris {
class PageCacheHandle;
+template <typename TAllocator>
+class PageBase : private TAllocator {
+public:
+ PageBase() : data(nullptr), size(0), bytes(0) {}
+
+ PageBase(size_t b) : size(b), bytes(b) {
+ data = reinterpret_cast<char*>(TAllocator::alloc(bytes,
ALLOCATOR_ALIGNMENT_16));
+ ExecEnv::GetInstance()->page_no_cache_mem_tracker()->consume(bytes);
+ }
+
+ PageBase(PageBase&& other) : data(other.data), size(other.size) {
+ std::swap(bytes, other.bytes);
+ }
+
+ ~PageBase() {
+ if (data != nullptr) {
+ DCHECK(bytes != 0 && size != 0);
+ TAllocator::free(data, bytes);
+
ExecEnv::GetInstance()->page_no_cache_mem_tracker()->release(bytes);
+ }
+ }
+
+ void reset_size(size_t n) {
+ DCHECK(n <= bytes);
+ size = n;
+ }
+
+ void release() {
Review Comment:
for page_cache_test.cpp, but it can be optimized
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
