lvshaokang commented on code in PR #19571:
URL: https://github.com/apache/doris/pull/19571#discussion_r1193287403
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/InsertStmt.java:
##########
@@ -117,7 +117,7 @@ public static class Properties {
// ---------------------------- for old insert stmt
----------------------------
public boolean isValuesOrConstantSelect() {
- throw new UnsupportedOperationException("only invoked in
NativeInsertStmt");
+ return false;
Review Comment:
beacuse of the insert stmt as the abstract class, execute to this point[1]
will throw exception when i tested. But I think this isn't correct.
[1]
https://github.com/apache/doris/blob/master/fe/fe-core/src/main/java/org/apache/doris/qe/ConnectProcessor.java#L324
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
