xinyiZzz commented on code in PR #19472:
URL: https://github.com/apache/doris/pull/19472#discussion_r1193186288
##########
be/src/olap/page_cache.h:
##########
@@ -85,7 +136,7 @@ class StoragePageCache {
// This function is thread-safe, and when two clients insert two same key
// concurrently, this function can assure that only one page is cached.
// The in_memory page will have higher priority.
- void insert(const CacheKey& key, const Slice& data, PageCacheHandle*
handle,
+ void insert(const CacheKey& key, DataPage<>& data, PageCacheHandle* handle,
Review Comment:
No, `DataPage` is a template class, `<>` must be specified, even if the
template parameter is the default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
