BiteTheDDDDt opened a new pull request, #19591:
URL: https://github.com/apache/doris/pull/19591

   # Proposed changes
   
   fix some wrong downcast founded by ubsan.
   ```cpp
   doris/be/src/olap/bloom_filter_predicate.h:43:32: runtime error: downcast of 
address 0x7f8ec2b691a0 which does not point to an object of type 
'doris::BloomFilterColumnPredicate<doris::TYPE_DATE>::SpecificFilter' (aka 
'BloomFilterFunc<(doris::PrimitiveType)11U>')
   0x7f8ec2b691a0: note: object is of type 
'doris::BloomFilterFunc<(doris::PrimitiveType)12>'
    e5 55 00 00  10 74 58 42 e5 55 00 00  00 00 10 00 8e 7f 00 00  20 07 6f cc 
8e 7f 00 00  80 fe 68 cc
                 ^~~~~~~~~~~~~~~~~~~~~~~
                 vptr for 'doris::BloomFilterFunc<(doris::PrimitiveType)12>'  
   ```
   1. TYPE_DATE/TYPE_DATETIME have same data format, so I change the cast about 
bloom filter to reinterpret cast.
   ```cpp
   doris/be/src/vec/exec/format/orc/vorc_reader.h:281:17: runtime error: 
downcast of address 0x7f562f4c3180 which does not point to an object of type 
'ColumnVector<int>'
   0x7f562f4c3180: note: object is of type 
'doris::vectorized::ColumnDecimal<doris::vectorized::Decimal<int> >'
    74 65 00 00  20 91 70 f5 ca 55 00 00  02 00 00 00 00 00 00 00  f0 d4 4c 2f 
56 7f 00 00  f0 d4 4c 2f
                 ^~~~~~~~~~~~~~~~~~~~~~~
                 vptr for 
'doris::vectorized::ColumnDecimal<doris::vectorized::Decimal<int> >'
   ```
   3. doris use ColumnDecimal to store decimal elements.
   
   ## Problem summary
   
   Describe your changes.
   
   ## Checklist(Required)
   
   * [ ] Does it affect the original behavior
   * [ ] Has unit tests been added
   * [ ] Has document been added or modified
   * [ ] Does it need to update dependencies
   * [ ] Is this PR support rollback (If NO, please explain WHY)
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to