xinyiZzz commented on code in PR #19526:
URL: https://github.com/apache/doris/pull/19526#discussion_r1191967326
##########
be/src/runtime/memory/mem_tracker.h:
##########
@@ -154,13 +154,13 @@ class MemTracker {
static void refresh_all_tracker_profile();
public:
- Snapshot make_snapshot() const;
+ virtual Snapshot make_snapshot() const;
Review Comment:
Why change it to `virtual`, where need to use `MemTrcker*` to call
`MemTrckerLimiter*`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
