dataroaring commented on code in PR #19099: URL: https://github.com/apache/doris/pull/19099#discussion_r1191832160
########## be/src/olap/memtable.cpp: ########## @@ -267,79 +218,137 @@ void MemTable::_aggregate_two_row_in_block(RowInBlock* new_row, RowInBlock* row_ new_row->_row_pos, nullptr); } } +void MemTable::_add_rows_from_block(vectorized::Block& in_block) { Review Comment: prepare_block_for_flush is a better name -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org