sohardforaname commented on code in PR #18209:
URL: https://github.com/apache/doris/pull/18209#discussion_r1189472301


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/util/TypeCoercionUtils.java:
##########
@@ -316,6 +317,13 @@ public static <T extends BinaryOperator> T 
processCharacterLiteralInBinaryOperat
     @Developing
     public static Optional<Expression> characterLiteralTypeCoercion(String 
value, DataType dataType) {
         Expression ret = null;
+        if (Config.enable_date_conversion) {
+            if (dataType instanceof DateType) {
+                dataType = DateV2Type.INSTANCE;
+            } else if (dataType instanceof DateTimeType) {
+                dataType = DateTimeV2Type.MAX;
+            }
+        }

Review Comment:
   because we will transform the datev1 type to datev2 type if enable date 
conversion.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to