morningman commented on code in PR #19365:
URL: https://github.com/apache/doris/pull/19365#discussion_r1189401735
##########
fe/fe-core/src/main/java/org/apache/doris/statistics/ColumnStatistic.java:
##########
@@ -138,10 +138,7 @@ public static ColumnStatistic fromResultRow(ResultRow
resultRow) {
String colName = resultRow.getColumnValue("col_id");
Column col = StatisticsUtil.findColumn(catalogId, dbID, tblId,
idxId, colName);
if (col == null) {
- LOG.warn("Failed to deserialize column statistics, ctlId: {}
dbId: {}"
- + "tblId: {} column: {} not exists",
- catalogId, dbID, tblId, colName);
- return ColumnStatistic.UNKNOWN;
+ return columnStatisticBuilder.build();
Review Comment:
Add some comment
##########
fe/fe-core/src/main/java/org/apache/doris/statistics/BaseAnalysisTask.java:
##########
@@ -142,6 +142,9 @@ private void init(AnalysisTaskInfo info) {
info, AnalysisState.FAILED,
String.format("Table with name %s not exists",
info.tblName), System.currentTimeMillis());
}
+ if (info.externalTableLevelTask) {
Review Comment:
Add some comment for this `if`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
