morningman commented on code in PR #19452:
URL: https://github.com/apache/doris/pull/19452#discussion_r1189382654
##########
regression-test/suites/correctness_p0/table_valued_function/test_backends_tvf.groovy:
##########
@@ -25,25 +25,25 @@ suite("test_backends_tvf") {
table = sql """ select BackendId, HostName, Alive, TotalCapacity, Version,
NodeRole from backends();"""
assertTrue(table.size() > 0) // row should > 0
assertTrue(table[0].size == 6) // column should be 26
- assertEquals("true", table[0][2])
+ assertEquals(true, table[0][2])
// case insensitive
table = sql """ select backendid, Hostname, alive, Totalcapacity, version,
nodeRole from backends();"""
assertTrue(table.size() > 0) // row should > 0
assertTrue(table[0].size == 6) // column should be 26
- assertEquals("true", table[0][2])
+ assertEquals(true, table[0][2])
// test aliase columns
table = sql """ select backendid as id, Hostname as name, alive, NodeRole
as r from backends();"""
assertTrue(table.size() > 0) // row should > 0
assertTrue(table[0].size == 4) // column should be 26
- assertEquals("true", table[0][2])
+ assertEquals(true, table[0][2])
// test changing position of columns
table = sql """ select Hostname as name, NodeRole as r, alive, ip from
backends();"""
assertTrue(table.size() > 0) // row should > 0
assertTrue(table[0].size == 4) // column should be 26
- assertEquals("true", table[0][2])
+ assertEquals(true, table[0][2])
Review Comment:
Please add count(*) case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
