morningman commented on code in PR #19369:
URL: https://github.com/apache/doris/pull/19369#discussion_r1189341493


##########
be/src/olap/data_dir.cpp:
##########
@@ -143,6 +144,14 @@ Status DataDir::_init_cluster_id() {
     return Status::OK();
 }
 
+Status DataDir::_init_decommission() {
+    auto path = fmt::format("{}/{}", _path, DECOMMISSION_PREFIX);

Review Comment:
   I think we don't need to save a file on BE.
   Only mark this disk as "decomission" on FE side, and let disk report do the 
rest, just like decommission a BE.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to