HHoflittlefish777 commented on code in PR #18874:
URL: https://github.com/apache/doris/pull/18874#discussion_r1187489885
##########
be/src/runtime/tablets_channel.cpp:
##########
@@ -107,12 +107,22 @@ Status TabletsChannel::open(const
PTabletWriterOpenRequest& request) {
_next_seqs.resize(_num_remaining_senders, 0);
_closed_senders.Reset(_num_remaining_senders);
- RETURN_IF_ERROR(_open_all_writers(request));
-
+ if (!config::enable_lazy_open_partition) {
+ RETURN_IF_ERROR(_open_all_writers(request));
Review Comment:
So in the config. h file **enable_ lazy_ open_ Partition** configuration is
used to control exceptions that may occur during upgrades, but the default
value I set is **true**. During the upgrade process, users need to set it to
**false** to avoid any issues.At first, I set it to false by default, but I was
worried that the added features after it would conflict with this
##########
be/src/runtime/tablets_channel.cpp:
##########
@@ -107,12 +107,22 @@ Status TabletsChannel::open(const
PTabletWriterOpenRequest& request) {
_next_seqs.resize(_num_remaining_senders, 0);
_closed_senders.Reset(_num_remaining_senders);
- RETURN_IF_ERROR(_open_all_writers(request));
-
+ if (!config::enable_lazy_open_partition) {
+ RETURN_IF_ERROR(_open_all_writers(request));
Review Comment:
So in the config. h file **enable_ lazy_ open_ Partition** configuration is
used to control exceptions that may occur during upgrades, but the default
value I set is **true**. During the upgrade process, users need to set it to
**false** to avoid any issues.At first, I set it to false by default, but I was
worried that the added features after it would conflict with this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
