wsjz commented on code in PR #18616:
URL: https://github.com/apache/doris/pull/18616#discussion_r1187192116


##########
fe/fe-core/src/main/java/org/apache/doris/planner/external/iceberg/IcebergScanNode.java:
##########
@@ -185,7 +186,10 @@ public List<Split> getSplits() throws UserException {
             long fileSize = task.file().fileSizeInBytes();
             for (FileScanTask splitTask : task.split(splitSize)) {
                 String dataFilePath = splitTask.file().path().toString();
-                IcebergSplit split = new IcebergSplit(new Path(dataFilePath), 
splitTask.start(),
+                // BE 无法识别 gs:// 开头的 file path,需要转换为 s3
+                // 为什么其他对象存储不需要转换? 例如 oss

Review Comment:
   到BE那边都转换成s3://了的,我觉得这个注释可以删掉



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to