[GitHub] [doris] felixwluo commented on pull request #19350: Enhancement-19322 add a session variable enable_pp_fuzzy

[via GitHub]

felixwluo commented on PR #19350:
URL: https://github.com/apache/doris/pull/19350#issuecomment-1537279683

   I think it's complicated. I'll make some changes
   
   奕冷 ***@***.***>于2023年5月7日 周日11:16写道：
   
   > ***@***.**** commented on this pull request.
   > ------------------------------
   >
   > In fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java
   > <https://github.com/apache/doris/pull/19350#discussion_r1186699508>:
   >
   > >          if (!isPointQuery) {
   > -            if (enablePipelineEngine) {
   > +            if (enablePipelineEngine && !enablePpFuzzy) {
   >                  sendPipelineCtx();
   > -            } else {
   > +            } else if (!enablePpFuzzy) {
   >                  sendFragment();
   >              }
   > -        } else {
   > +        } else if (!enablePpFuzzy) {
   >              OlapScanNode planRoot = (OlapScanNode) 
fragments.get(0).getPlanRoot();
   >              Preconditions.checkState(planRoot.getScanTabletIds().size() 
== 1);
   >              pointExec.setCandidateBackends(planRoot.getScanBackendIds());
   >
   > How about using
   >
   > if (enablePpFuzzy) {
   >     return;
   > }
   >
   > to skip the logic below?
   > ------------------------------
   >
   > In fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java
   > <https://github.com/apache/doris/pull/19350#discussion_r1186700724>:
   >
   > > @@ -352,6 +353,10 @@ public class SessionVariable implements 
Serializable, Writable {
   >      @VariableMgr.VarAttr(name = ENABLE_PROFILE, needForward = true)
   >      public boolean enableProfile = false;
   >
   > +    // if true, coordinator do not send planfragment to be, and just ends 
the query.
   > +    @VariableMgr.VarAttr(name = ENABLE_PP_FUZZY)
   >
   > Does it need to forward to master?
   >
   > —
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/doris/pull/19350#pullrequestreview-1415778393>,
   > or unsubscribe
   > 
<https://github.com/notifications/unsubscribe-auth/A7KEOOIVZ5CTTD6K2TKNGJ3XE4HX5ANCNFSM6AAAAAAXYBB7SU>
   > .
   > You are receiving this because you authored the thread.Message ID:
   > ***@***.***>
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org