lvshaokang commented on code in PR #19142: URL: https://github.com/apache/doris/pull/19142#discussion_r1185860897
########## fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java: ########## @@ -629,7 +644,7 @@ public void executeByLegacy(TUniqueId queryId) throws Exception { if (!context.isTxnModel()) { Span queryAnalysisSpan = context.getTracer().spanBuilder("query analysis").setParent(Context.current()).startSpan(); - try (Scope scope = queryAnalysisSpan.makeCurrent()) { + try (Scope ignored = queryAnalysisSpan.makeCurrent()) { Review Comment: > `try (queryAnalysisSpan.makeCurrent()) {` maybe not reasonable in Java8, a compile error will be raised. sry, I ignored this. Is there still support for jdk8 compilation? On my side, i used jdk11. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org