zhannngchen commented on code in PR #19262:
URL: https://github.com/apache/doris/pull/19262#discussion_r1185821375
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/InsertStmt.java:
##########
@@ -150,6 +155,21 @@ public InsertStmt(InsertTarget target, String label,
List<String> cols, InsertSo
&& ((SelectStmt) queryStmt).getTableRefs().isEmpty());
}
+ public InsertStmt(InsertTarget target, String label, List<String> cols,
InsertSource source,
+ List<String> hints, boolean isPartialUpdate) {
+ this.tblName = target.getTblName();
Review Comment:
L160-L165 can be replaced with `this(target, label, cols, source, hints)?`
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/UpdateStmt.java:
##########
@@ -118,13 +118,19 @@ private void constructInsertStmt() {
// limit
LimitElement.NO_LIMIT
);
+ boolean isPartialUpdate = false;
+ if (((OlapTable) targetTable).getEnableUniqueKeyMergeOnWrite()
+ && cols.size() < targetTable.getColumns().size()) {
Review Comment:
consider < 50% of total columns?
e.g. If user update 9 of total 10 columns, seems not necessary to leverage
partial update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
