github-actions[bot] commented on code in PR #19303: URL: https://github.com/apache/doris/pull/19303#discussion_r1185790445
########## be/src/gutil/atomicops.h: ########## @@ -66,18 +66,19 @@ // #endif // ------------------------------------------------------------------------ -#define GCC_VERSION (__GNUC__ * 10000 + __GNUC_MINOR__ * 100 + __GNUC_PATCHLEVEL__) +#define GUTILS_GCC_VERSION (__GNUC__ * 10000 + __GNUC_MINOR__ * 100 + __GNUC_PATCHLEVEL__) Review Comment: warning: macro is not used [clang-diagnostic-unused-macros] ```cpp #define GUTILS_GCC_VERSION (__GNUC__ * 10000 + __GNUC_MINOR__ * 100 + __GNUC_PATCHLEVEL__) ^ ``` ########## be/src/gutil/atomicops.h: ########## @@ -66,18 +66,19 @@ // #endif // ------------------------------------------------------------------------ -#define GCC_VERSION (__GNUC__ * 10000 + __GNUC_MINOR__ * 100 + __GNUC_PATCHLEVEL__) +#define GUTILS_GCC_VERSION (__GNUC__ * 10000 + __GNUC_MINOR__ * 100 + __GNUC_PATCHLEVEL__) -#define CLANG_VERSION (__clang_major__ * 10000 + __clang_minor__ * 100 + __clang_patchlevel__) +#define GUTILS_CLANG_VERSION \ Review Comment: warning: macro is not used [clang-diagnostic-unused-macros] ```cpp #define GUTILS_CLANG_VERSION \ ^ ``` ########## be/src/pch/pch.h: ########## @@ -0,0 +1,523 @@ +// CLucene headers +#include <CLucene.h> +#include <CLucene/analysis/LanguageBasedAnalyzer.h> +#include <CLucene/clucene-config.h> +#include <CLucene/debug/error.h> +#include <CLucene/debug/mem.h> +#include <CLucene/index/IndexReader.h> +#include <CLucene/search/IndexSearcher.h> +#include <CLucene/store/Directory.h> +#include <CLucene/store/IndexInput.h> +#include <CLucene/store/IndexOutput.h> +#include <CLucene/store/RAMDirectory.h> +#include <CLucene/util/Misc.h> +#include <CLucene/util/bkd/bkd_reader.h> + +// arrow headers +#include <arrow/array/array_base.h> +#include <arrow/array/array_decimal.h> +#include <arrow/array/array_primitive.h> +#include <arrow/array/builder_base.h> +#include <arrow/array/builder_binary.h> +#include <arrow/array/builder_decimal.h> +#include <arrow/array/builder_nested.h> +#include <arrow/array/builder_primitive.h> +#include <arrow/array/data.h> +#include <arrow/buffer.h> +#include <arrow/io/interfaces.h> +#include <arrow/io/memory.h> +#include <arrow/io/type_fwd.h> +#include <arrow/ipc/writer.h> +#include <arrow/pretty_print.h> +#include <arrow/record_batch.h> +#include <arrow/result.h> +#include <arrow/status.h> +#include <arrow/type.h> +#include <arrow/type_fwd.h> +#include <arrow/util/decimal.h> +#include <arrow/visit_type_inline.h> +#include <arrow/visitor.h> + +// aws headers +#include <aws/core/Aws.h> +#include <aws/core/auth/AWSAuthSigner.h> +#include <aws/core/auth/AWSCredentials.h> +#include <aws/core/client/AWSError.h> +#include <aws/core/client/ClientConfiguration.h> +#include <aws/core/http/HttpResponse.h> +#include <aws/core/utils/Array.h> +#include <aws/core/utils/HashingUtils.h> +#include <aws/core/utils/Outcome.h> +#include <aws/core/utils/logging/LogLevel.h> +#include <aws/core/utils/logging/LogSystemInterface.h> +#include <aws/core/utils/memory/stl/AWSAllocator.h> +#include <aws/core/utils/memory/stl/AWSMap.h> +#include <aws/core/utils/memory/stl/AWSStreamFwd.h> +#include <aws/core/utils/memory/stl/AWSString.h> +#include <aws/core/utils/memory/stl/AWSStringStream.h> +#include <aws/core/utils/memory/stl/AWSVector.h> +#include <aws/core/utils/stream/PreallocatedStreamBuf.h> +#include <aws/core/utils/threading/Executor.h> +#include <aws/s3/S3Client.h> +#include <aws/s3/S3Errors.h> +#include <aws/s3/model/AbortMultipartUploadRequest.h> +#include <aws/s3/model/AbortMultipartUploadResult.h> +#include <aws/s3/model/CompleteMultipartUploadRequest.h> +#include <aws/s3/model/CompleteMultipartUploadResult.h> +#include <aws/s3/model/CompletedMultipartUpload.h> +#include <aws/s3/model/CompletedPart.h> +#include <aws/s3/model/CopyObjectRequest.h> +#include <aws/s3/model/CopyObjectResult.h> +#include <aws/s3/model/CreateMultipartUploadRequest.h> +#include <aws/s3/model/CreateMultipartUploadResult.h> +#include <aws/s3/model/Delete.h> +#include <aws/s3/model/DeleteObjectRequest.h> +#include <aws/s3/model/DeleteObjectResult.h> +#include <aws/s3/model/DeleteObjectsRequest.h> +#include <aws/s3/model/DeleteObjectsResult.h> +#include <aws/s3/model/Error.h> +#include <aws/s3/model/GetObjectRequest.h> +#include <aws/s3/model/GetObjectResult.h> +#include <aws/s3/model/HeadObjectRequest.h> +#include <aws/s3/model/HeadObjectResult.h> +#include <aws/s3/model/ListObjectsV2Request.h> +#include <aws/s3/model/ListObjectsV2Result.h> +#include <aws/s3/model/Object.h> +#include <aws/s3/model/ObjectIdentifier.h> +#include <aws/s3/model/PutObjectRequest.h> +#include <aws/s3/model/PutObjectResult.h> +#include <aws/s3/model/UploadPartRequest.h> +#include <aws/s3/model/UploadPartResult.h> +#include <aws/transfer/TransferHandle.h> +#include <aws/transfer/TransferManager.h> + +// bitshuffle headers +#include <bitshuffle/bitshuffle.h> + +// brpc headers +#include <brpc/adaptive_connection_type.h> +#include <brpc/adaptive_protocol_type.h> +#include <brpc/callback.h> +#include <brpc/channel.h> +#include <brpc/closure_guard.h> +#include <brpc/controller.h> +#include <brpc/http_header.h> +#include <brpc/http_method.h> +#include <brpc/server.h> +#include <brpc/ssl_options.h> +#include <brpc/uri.h> + +// bthread headers +#include <bthread/bthread.h> +#include <bthread/condition_variable.h> +#include <bthread/mutex.h> +#include <bthread/types.h> + +// butil headers +#include <butil/endpoint.h> +#include <butil/errno.h> +#include <butil/fast_rand.h> +#include <butil/fd_utility.h> +#include <butil/iobuf.h> +#include <butil/iobuf_inl.h> +#include <butil/macros.h> +#include <butil/time.h> + +// bvar headers +#include <bvar/bvar.h> +#include <bvar/latency_recorder.h> +#include <bvar/reducer.h> +#include <bvar/window.h> + +// cctz headers +#include <cctz/civil_time.h> +#include <cctz/civil_time_detail.h> +#include <cctz/time_zone.h> + +// event2 headers +#include <event2/buffer.h> +#include <event2/event.h> +#include <event2/http.h> +#include <event2/http_struct.h> +#include <event2/keyvalq_struct.h> +#include <event2/thread.h> + +// fast_float headers +#include <fast_float/fast_float.h> +#include <fast_float/parse_number.h> + +// fmt headers +#include <fmt/core.h> +#include <fmt/format.h> +#include <fmt/ranges.h> + +// gen_cpp headers +#include <gen_cpp/AgentService_types.h> Review Comment: warning: 'gen_cpp/AgentService_types.h' file not found [clang-diagnostic-error] ```cpp #include <gen_cpp/AgentService_types.h> ^ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org