Kikyou1997 commented on code in PR #19247:
URL: https://github.com/apache/doris/pull/19247#discussion_r1185669201
##########
fe/fe-core/src/main/java/org/apache/doris/statistics/AnalysisTaskInfoBuilder.java:
##########
@@ -147,18 +161,44 @@ public AnalysisTaskInfoBuilder copy() {
.setCatalogName(catalogName)
.setDbName(dbName)
.setTblName(tblName)
- .setPartitionNames(partitionNames)
+ .setColToPartitions(colToPartitions)
.setColName(colName)
.setIndexId(indexId)
.setJobType(jobType)
+ .setAnalysisMode(analysisMode)
.setAnalysisMethod(analysisMethod)
.setAnalysisType(analysisType)
.setSamplePercent(samplePercent)
.setSampleRows(sampleRows)
+ .setPeriodTimeInMs(periodTimeInMs)
.setMaxBucketNum(maxBucketNum)
.setMessage(message)
.setLastExecTimeInMs(lastExecTimeInMs)
.setState(state)
.setScheduleType(scheduleType);
}
+
+ public static AnalysisTaskInfoBuilder getFromJobInfo(AnalysisTaskInfo
info) {
Review Comment:
Quite wired here, it named as `getFromJobInfo` however all this method done
is just copying field from another `AnalysisTaskInfo`, so why just add a
constructor like `public AnalysisTaskInfoBuilder(AnalysisTaskInfo info)`
##########
fe/fe-core/src/main/java/org/apache/doris/statistics/AnalysisTaskInfoBuilder.java:
##########
@@ -147,18 +161,44 @@ public AnalysisTaskInfoBuilder copy() {
.setCatalogName(catalogName)
.setDbName(dbName)
.setTblName(tblName)
- .setPartitionNames(partitionNames)
+ .setColToPartitions(colToPartitions)
.setColName(colName)
.setIndexId(indexId)
.setJobType(jobType)
+ .setAnalysisMode(analysisMode)
.setAnalysisMethod(analysisMethod)
.setAnalysisType(analysisType)
.setSamplePercent(samplePercent)
.setSampleRows(sampleRows)
+ .setPeriodTimeInMs(periodTimeInMs)
.setMaxBucketNum(maxBucketNum)
.setMessage(message)
.setLastExecTimeInMs(lastExecTimeInMs)
.setState(state)
.setScheduleType(scheduleType);
}
+
+ public static AnalysisTaskInfoBuilder getFromJobInfo(AnalysisTaskInfo
info) {
Review Comment:
Quite wired here, it named as `getFromJobInfo` however all this method done
is just copying field from another `AnalysisTaskInfo`, so why don't just add a
constructor like `public AnalysisTaskInfoBuilder(AnalysisTaskInfo info)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
