CalvinKirs commented on PR #19255: URL: https://github.com/apache/doris/pull/19255#issuecomment-1535593803
> > > > Hi, These are already defined in the parent pom, so we can refer to them directly > > > > [https://github.com/apache/doris/blob/master/fe/pom.xml#L193-L195↳](https://github.com/apache/doris/blob/master/fe/pom.xml#L193-L195%E2%86%B3) > > > > > > > > > I knew the modification you mentioned, but it seems that the new place can't activate the profile `protoc_command` (details see the above description). > > > > > > quick look issue, ```/lib64/libc.so.6: version `GLIBC_2.14' not found (required by /tmp/protoc939416317298399877.exe) [ERROR] /Programs/doris/fe/../gensrc/proto/olap_file.proto [0:0]:↳ > > ``` > > It seems that the issue has nothing to do with this change. > > Please let me know if I missed something. > > ``` > > Hi @CalvinKirs , the root cause of this issue is that the plugin `protoc-jar-maven-plugin` provides a pre-built binary of `protoc` which was built against GLIBC 2.14 (maybe on Centos 7). The version of GLIBC on Centos 6 is 2.12, so we can't use `protoc` downloaded by the plugin directly on Centos 6.↳ > > As a workaround, we can use the configuration `protocCommand` provided by the plugin `protoc-jar-maven-plugin` to specify a `protoc` exectuable to compile the proto files. If we execute `thirdparty/build-thirdparty.sh`, we will build `protobuf` from source and get a `protoc` executable which works on Centos 6.↳ > > We provided a profile (https://github.com/apache/doris/blob/master/fe/fe-core/pom.xml#L72-L82) to apply this workaround. If the `protoc` built from source is available, we specify the property `protoc.command` and pass it to `protocCommand`. However, #18882 broke this mechanism. The new place can't activate the profile because the activation depends on the property `doris.thirdparty` which is improper at the time when maven checks the activation of a profile.↳ got it, thanks:) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
