github-actions[bot] commented on code in PR #18654:
URL: https://github.com/apache/doris/pull/18654#discussion_r1184600418
##########
be/src/exec/rowid_fetcher.cpp:
##########
@@ -48,11 +52,15 @@
#include "vec/common/assert_cast.h"
#include "vec/common/string_ref.h"
#include "vec/core/block.h" // Block
+#include "vec/data_types/data_type_factory.hpp"
+#include "vec/jsonb/serialize.h"
namespace doris {
-Status RowIDFetcher::init(DorisNodesInfo* nodes_info) {
- for (auto [node_id, node_info] : nodes_info->nodes_info()) {
+Status RowIDFetcher::init() {
Review Comment:
warning: method 'init' can be made const
[readability-make-member-function-const]
```suggestion
Status RowIDFetcher::init() const {
```
be/src/exec/rowid_fetcher.h:54:
```diff
- Status init();
+ Status init() const;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
