morningman commented on code in PR #19233:
URL: https://github.com/apache/doris/pull/19233#discussion_r1184479905
##########
be/src/vec/exec/scan/vscanner.cpp:
##########
@@ -88,6 +88,8 @@ Status VScanner::get_block(RuntimeState* state, Block* block,
bool* eof) {
}
// record rows return (after filter) for _limit check
_num_rows_return += block->rows();
+ // record the size during process
+ _counter.size_rows_bytes_read += block->bytes();
Review Comment:
It may impact the performance? Because `bytes()` is calc column by column
##########
be/src/runtime/runtime_state.h:
##########
@@ -221,6 +221,8 @@ class RuntimeState {
int64_t num_bytes_load_total() { return _num_bytes_load_total.load(); }
+ int64_t num_bytes_load_scanner_total() { return
_num_bytes_load_scanner_total.load(); }
Review Comment:
What is diff between this and `_num_bytes_load_total` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
