morningman commented on code in PR #19170: URL: https://github.com/apache/doris/pull/19170#discussion_r1184457473
########## fe/fe-core/src/main/java/org/apache/doris/load/loadv2/ProgressManager.java: ########## @@ -0,0 +1,142 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.load.loadv2; + +import org.apache.doris.thrift.TUniqueId; + +import com.google.common.collect.HashBasedTable; +import com.google.common.collect.Maps; +import com.google.common.collect.Table; +import org.apache.logging.log4j.LogManager; +import org.apache.logging.log4j.Logger; + +import java.util.Map; + +/** + * ProgressManager manage the progress of loading and exporting tasks + */ +public class ProgressManager { + private static final Logger LOG = LogManager.getLogger(ProgressManager.class); + + private Map<String, Progress> idToProgress = Maps.newConcurrentMap(); + + public void registerProgress(String id, int scannerNum) { + LOG.debug("create {} with initial scannerNum {}", id, scannerNum); + idToProgress.remove(id); + idToProgress.put(id, new Progress(scannerNum)); + } + + public void registerProgressSimple(String id) { + registerProgress(id, 0); + } + + public void updateProgress(String id, TUniqueId queryId, TUniqueId fragmentId, int finishedScannerNum) { + Progress progress = idToProgress.get(id); + if (progress != null) { + progress.updateFinishedScanNums(queryId, fragmentId, finishedScannerNum); + } else { + LOG.warn("progress[" + id + "] missing meta infomartion"); + } + } + + public void addTotalScanNums(String id, int num) { + Progress progress = idToProgress.get(id); + if (progress != null) { + progress.addTotalScanNums(num); + } + } + + public void deregisterProgress(String id) { + // TODO: deregister the progress + idToProgress.remove(id); + } + + public Progress getProgressClass(String id) { Review Comment: Remove unused method ########## fe/fe-core/src/main/java/org/apache/doris/load/loadv2/ProgressManager.java: ########## @@ -0,0 +1,142 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.load.loadv2; + +import org.apache.doris.thrift.TUniqueId; + +import com.google.common.collect.HashBasedTable; +import com.google.common.collect.Maps; +import com.google.common.collect.Table; +import org.apache.logging.log4j.LogManager; +import org.apache.logging.log4j.Logger; + +import java.util.Map; + +/** + * ProgressManager manage the progress of loading and exporting tasks + */ +public class ProgressManager { + private static final Logger LOG = LogManager.getLogger(ProgressManager.class); + + private Map<String, Progress> idToProgress = Maps.newConcurrentMap(); + + public void registerProgress(String id, int scannerNum) { + LOG.debug("create {} with initial scannerNum {}", id, scannerNum); + idToProgress.remove(id); + idToProgress.put(id, new Progress(scannerNum)); + } + + public void registerProgressSimple(String id) { + registerProgress(id, 0); + } + + public void updateProgress(String id, TUniqueId queryId, TUniqueId fragmentId, int finishedScannerNum) { + Progress progress = idToProgress.get(id); + if (progress != null) { + progress.updateFinishedScanNums(queryId, fragmentId, finishedScannerNum); + } else { + LOG.warn("progress[" + id + "] missing meta infomartion"); + } + } + + public void addTotalScanNums(String id, int num) { + Progress progress = idToProgress.get(id); + if (progress != null) { + progress.addTotalScanNums(num); + } + } + + public void deregisterProgress(String id) { + // TODO: deregister the progress + idToProgress.remove(id); + } + + public Progress getProgressClass(String id) { + return idToProgress.get(id); + } + + public double getProgress(String id) { Review Comment: Remove unused method ########## fe/fe-core/src/main/java/org/apache/doris/load/loadv2/ProgressManager.java: ########## @@ -0,0 +1,142 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.load.loadv2; + +import org.apache.doris.thrift.TUniqueId; + +import com.google.common.collect.HashBasedTable; +import com.google.common.collect.Maps; +import com.google.common.collect.Table; +import org.apache.logging.log4j.LogManager; +import org.apache.logging.log4j.Logger; + +import java.util.Map; + +/** + * ProgressManager manage the progress of loading and exporting tasks + */ +public class ProgressManager { + private static final Logger LOG = LogManager.getLogger(ProgressManager.class); + + private Map<String, Progress> idToProgress = Maps.newConcurrentMap(); + + public void registerProgress(String id, int scannerNum) { + LOG.debug("create {} with initial scannerNum {}", id, scannerNum); + idToProgress.remove(id); + idToProgress.put(id, new Progress(scannerNum)); + } + + public void registerProgressSimple(String id) { + registerProgress(id, 0); + } + + public void updateProgress(String id, TUniqueId queryId, TUniqueId fragmentId, int finishedScannerNum) { + Progress progress = idToProgress.get(id); + if (progress != null) { + progress.updateFinishedScanNums(queryId, fragmentId, finishedScannerNum); + } else { + LOG.warn("progress[" + id + "] missing meta infomartion"); + } + } + + public void addTotalScanNums(String id, int num) { + Progress progress = idToProgress.get(id); + if (progress != null) { + progress.addTotalScanNums(num); + } + } + + public void deregisterProgress(String id) { + // TODO: deregister the progress + idToProgress.remove(id); + } + + public Progress getProgressClass(String id) { + return idToProgress.get(id); + } + + public double getProgress(String id) { + return idToProgress.get(id).getProgress(); + } + + public String getProgressInfo(String id) { + String progressResult = "ERROR"; Review Comment: ```suggestion String progressResult = "Unknown id: " + id; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
