ZhangYu0123 commented on code in PR #19241:
URL: https://github.com/apache/doris/pull/19241#discussion_r1183693960


##########
regression-test/suites/inverted_index_p1/tpcds_sf1_index/ddl/call_center.sql:
##########
@@ -1,8 +1,8 @@
 CREATE TABLE IF NOT EXISTS call_center (
     cc_call_center_sk bigint,
     cc_call_center_id char(16),
-    cc_rec_start_date date,
-    cc_rec_end_date date,
+    cc_rec_start_date datev2,

Review Comment:
   > do not need do this, we should submit a PR, to allow create a column with 
date type, but the underlying type is datev2
   
   i was not plan to do this, i just commited something to run the p1 test by 
reset the master version.  I find q72.sql p1 timeout error may 
    be caused by runtime filter policy changing  
https://github.com/apache/doris/pull/18828.  



##########
regression-test/suites/inverted_index_p1/tpcds_sf1_index/ddl/call_center.sql:
##########
@@ -1,8 +1,8 @@
 CREATE TABLE IF NOT EXISTS call_center (
     cc_call_center_sk bigint,
     cc_call_center_id char(16),
-    cc_rec_start_date date,
-    cc_rec_end_date date,
+    cc_rec_start_date datev2,

Review Comment:
   > do not need do this, we should submit a PR, to allow create a column with 
date type, but the underlying type is datev2
   
   i was not plan to do this, i just commited something to run the p1 test by 
reset the master version.  
   I find q72.sql p1 timeout error may 
    be caused by runtime filter policy changing  
https://github.com/apache/doris/pull/18828.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to