jackwener commented on code in PR #18747:
URL: https://github.com/apache/doris/pull/18747#discussion_r1178992488
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/Plan.java:
##########
@@ -90,6 +91,16 @@ default boolean displayExtraPlanFirst() {
List<Slot> getNonUserVisibleOutput();
+ default JSONObject toJson() {
+ JSONObject json = new JSONObject();
+ json.put("PlanType", getType().toString());
+ return json;
+ }
+
+ default Plan readFromJson(JSONObject jsonObject) {
+ return withLogicalProperties(null);
+ }
+
Review Comment:
It's redundant, we don't need add default, because we already have
`AbstractPlan.java`, all plan already extends it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
