Bingandbing commented on code in PR #18747:
URL: https://github.com/apache/doris/pull/18747#discussion_r1178842263


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalBinary.java:
##########
@@ -43,4 +46,16 @@ public LogicalBinary(PlanType type, 
Optional<GroupExpression> groupExpression,
     }
 
     public abstract List<Slot> computeOutput();
+
+    @Override
+    public JSONObject toJson() {
+        JSONObject json = new JSONObject();
+        json.put("PlanType", getType().toString());
+        JSONArray childrenJson = new JSONArray();
+        for (Plan child : children) {
+            childrenJson.put(child.toJson());
+        }
+        json.put("children", childrenJson);
+        return json;
+    }

Review Comment:
   I considered this implementation when start doing this part, but found 
leafPlan do not have children member, so this can not be done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to