imay commented on a change in pull request #3571:
URL: https://github.com/apache/incubator-doris/pull/3571#discussion_r427413916



##########
File path: 
docs/en/sql-reference/sql-functions/bitmap-functions/bitmap_intersect.md
##########
@@ -0,0 +1,54 @@
+---
+{
+    "title": "bitmap_intersect",
+    "language": "en"

Review comment:
       should add this file to sidebar to make it visible. 

##########
File path: be/src/exprs/bitmap_function.cpp
##########
@@ -302,6 +302,31 @@ void BitmapFunctions::bitmap_union(FunctionContext* ctx, 
const StringVal& src, S
     }
 }
 
+// this is the read init function for bitmap_intersect
+void BitmapFunctions::bitmap_intersect_init_real(FunctionContext* ctx, 
StringVal* dst) {
+    dst->is_null = true;

Review comment:
       why initial result bitmap as null? it seems that it will return empty 
bitmap when result bitmap is null




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to