kangkaisen commented on a change in pull request #3571:
URL: https://github.com/apache/incubator-doris/pull/3571#discussion_r427403092
##########
File path: be/src/exprs/bitmap_function.cpp
##########
@@ -302,6 +302,31 @@ void BitmapFunctions::bitmap_union(FunctionContext* ctx,
const StringVal& src, S
}
}
+// this is the read init function for bitmap_intersect
+void BitmapFunctions::bitmap_intersect_init_real(FunctionContext* ctx,
StringVal* dst) {
+ dst->is_null = true;
+}
+
+void BitmapFunctions::bitmap_intersect(FunctionContext* ctx, const StringVal&
src, StringVal* dst) {
+ if (src.is_null) {
+ return;
+ }
+ // if dst is null, the src input is the first value
+ if (dst->is_null) {
Review comment:
Would better add a `UNLIKELY` macros.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
